-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix core sched conflicts with GI and revise API #1829
koordlet: fix core sched conflicts with GI and revise API #1829
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
+ Coverage 67.03% 67.06% +0.03%
==========================================
Files 407 407
Lines 45557 45716 +159
==========================================
+ Hits 30538 30659 +121
- Misses 12796 12820 +24
- Partials 2223 2237 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
943577a
to
4eaeb49
Compare
4eaeb49
to
bb19d80
Compare
为啥要在这里覆盖上面的 core-sched-group-id,而不是直接修改 core-sched-group-id? |
“关闭 core sched” 和 “与所有其他 pod 互斥” 其实都应该能通过配置 “group--id” 来支持,但单独维护这样的分组策略是有成本的,而 policy 协议主要是基于分组机制提供特殊配置方案。独立协议的另一原因是,在应急运维和灰度场景下,可以简单打标 policy 协议来把 pod 标记为关闭或强隔离,随后删去该协议即可恢复原有分组,不需要单独维护临时分组。 |
7f7c869
to
1d6a742
Compare
/lgtm |
koordlet: revise core sched group api Signed-off-by: saintube <saintube@foxmail.com>
1d6a742
to
6d83897
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r-sh#1829) Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
…r-sh#1829) Signed-off-by: saintube <saintube@foxmail.com>
…r-sh#1829) Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
…r-sh#1829) Signed-off-by: saintube <saintube@foxmail.com>
Ⅰ. Describe what this PR does
koordinator.sh/core-sched-policy
that can define if the core sched is disabled or make it an individual group exclusive to others. When the labelkoordinator.sh/core-sched-group-id
is not set, we no longer consider it an exclusive policy, instead we regard it as an empty group ID.Ⅱ. Does this pull request fix one issue?
Part of #1728 (2.1).
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
See #1728 (2.2). After the Anolis kernel fixes the compatibility problem and provides a more stable interface, koordlet removes the workaround about when the node's CPU QoS policy is migrating from Group Identity to Core Scheduling.
V. Checklist
make test